Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ApiFutures.successfulAsList #163

Merged
merged 1 commit into from Jul 17, 2020
Merged

feat: add ApiFutures.successfulAsList #163

merged 1 commit into from Jul 17, 2020

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Jul 14, 2020

I would like to use this in the java-firestore repo. This PR exposes ApiFutures.successfulAsList (link).

Here is a PR that uses it (link). successfulAsList allows me to wait for all Futures to complete (ApiFutures.allAsList completes early if an exception is thrown) before I run my listener. The alternative implementation without this method would be to manually add listeners to all the ApiFutures in order to handle exceptions.

@googlebot googlebot added the cla: yes label Jul 14, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 14, 2020

Codecov Report

Merging #163 into master will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #163      +/-   ##
============================================
+ Coverage     64.43%   64.68%   +0.24%     
- Complexity      174      175       +1     
============================================
  Files            14       14              
  Lines           717      722       +5     
  Branches        120      120              
============================================
+ Hits            462      467       +5     
  Misses          219      219              
  Partials         36       36              
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/google/api/core/ApiFutures.java 87.03% <100.00%> (+1.32%) 12.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fad49d...43b931b. Read the comment docs.

@thebrianchen thebrianchen marked this pull request as ready for review Jul 14, 2020
@BenWhitehead BenWhitehead self-requested a review Jul 14, 2020
Copy link

@BenWhitehead BenWhitehead left a comment

This looks okay to me. @chingor13 does this seem okay to you?

@BenWhitehead BenWhitehead requested a review from chingor13 Jul 14, 2020
@BenWhitehead BenWhitehead self-assigned this Jul 14, 2020
@chingor13 chingor13 requested review from miraleung and vam-google Jul 16, 2020
Copy link
Collaborator

@vam-google vam-google left a comment

LGTM

@BenWhitehead BenWhitehead merged commit 6af8e24 into googleapis:master Jul 17, 2020
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants