fix: Permit full_resource_name as a field name. (#583)

googleapis · Jul 17, 2020 · 9b82a04 · 9b82a04
1 parent dc24c16
commit 9b82a04
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/docs/rules/0122/name-suffix.md b/docs/rules/0122/name-suffix.md
@@ -18,7 +18,8 @@ This rule enforces that fields do not use the suffix `_name`, as mandated in
 This rule scans all fields complains if it sees the suffix `_name` on a field.
 
 **Note:** The standard field `display_name` is exempt, as are `given_name` and
-`family_name` (used to represent the human-readable name of a person).
+`family_name` (used to represent the human-readable name of a person), and
+`full_resource_name`.
 
 ## Examples
 

diff --git a/rules/aip0122/name_suffix.go b/rules/aip0122/name_suffix.go
@@ -30,6 +30,7 @@ var nameSuffix = &lint.FieldRule{
 			"display_name",
 			"family_name",
 			"given_name",
+			"full_resource_name",
 			"name",
 		).Contains(f.GetName())
 	},

diff --git a/rules/aip0122/name_suffix_test.go b/rules/aip0122/name_suffix_test.go
@@ -30,6 +30,7 @@ func TestNameSuffix(t *testing.T) {
 		{"ValidStandardDisplay", "display_name", testutils.Problems{}},
 		{"ValidStandardGiven", "given_name", testutils.Problems{}},
 		{"ValidStandardFamily", "family_name", testutils.Problems{}},
+		{"ValidStandardFull", "full_resource_name", testutils.Problems{}},
 		{"Invalid", "author_name", testutils.Problems{{Suggestion: "author"}}},
 	} {
 		f := testutils.ParseProto3Tmpl(t, `