Skip to content
This repository has been archived by the owner on Mar 1, 2022. It is now read-only.

Fix Python style issues, add linting to CI #277

Closed
geigerj opened this issue Sep 15, 2017 · 2 comments
Closed

Fix Python style issues, add linting to CI #277

geigerj opened this issue Sep 15, 2017 · 2 comments
Assignees
@lukesneeringer
Labels
P2 type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@geigerj
Copy link
Contributor

geigerj commented Sep 15, 2017 •
edited by lukesneeringer
Loading

Running nox -e lint shows dozens of Python style violations. The linter environment is not being run in travis, allowing these style violations to accumulate. We should fix the existing violations, then enable the linter in travis Circle.
@geigerj geigerj mentioned this issue Sep 21, 2017
Merged
@ethanbao
Copy link
Contributor

Many lint warnings are currently introduced by main.py, which I am going to drop starting 0.5.*. I will add the linting to CI after that.

@lukesneeringer
Copy link
Contributor

I would actually prefer not run pylint, but we should run flake8.

saicheems pushed a commit to saicheems/artman that referenced this issue Oct 12, 2017
@chrisdunelm
Add static types to spanner admin (googleapis#277)
affaa1d 
Except for IAM methods
@ethanbao ethanbao assigned lukesneeringer and unassigned ethanbao Feb 23, 2018
@JustinBeckwith JustinBeckwith added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lukesneeringer lukesneeringer

Labels
P2 type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lukesneeringer @JustinBeckwith @vchudnov-g @ethanbao @geigerj