This repository has been archived by the owner on Mar 1, 2022. It is now read-only.
fix --local runs #650
Merged
fix --local runs #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
vam-google
approved these changes
Jun 26, 2019
|
@vam-google If you have a merge conflict while reverting, feel free to add me and I'll fix it. Or, feel free to revert both since my change does not make any sense without #637. |
alexander-fenster
added a commit
that referenced
this pull request
Jun 26, 2019
Changes included in this release are fixes: In artman: - pass the specific YAML loader to yaml.load #648 - fix --local runs #650 In gapic-generator: - samplegen: add sample_config.proto to the config_java_proto BUILD target googleapis/gapic-generator#2852 - go: URL encode x-goog-request-params googleapis/gapic-generator#2851 - ruby: ake it possible to pass metadata to the operations client googleapis/gapic-generator#2856
Merged
alexander-fenster
added a commit
that referenced
this pull request
Jun 26, 2019
Changes included in this release are fixes: In artman: - pass the specific YAML loader to yaml.load #648 - fix --local runs #650 In gapic-generator: - samplegen: add sample_config.proto to the config_java_proto BUILD target googleapis/gapic-generator#2852 - go: URL encode x-goog-request-params googleapis/gapic-generator#2851 - ruby: ake it possible to pass metadata to the operations client googleapis/gapic-generator#2856
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #649. The
protocversions PR #637 broke--localruns. My understanding is that the PR approach is just wrong and it should be reverted and/or changed, but if we don't revert it right now, let's at least make local runs work by not failing because of the missing script and having reasonable default value forprotoccommand (which is, obviously, justprotocwithout any specific version).