This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Debugging transpiled code changes the breakpoint line number #417
Labels
api: clouddebugger
Issues related to the googleapis/cloud-debug-nodejs API.
🚨
This issue needs some love.
triage me
I really want to be triaged.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
Thank you for letting us know about this and for looking into this. As we work through this, we will keep this thread updated with status updates. |
Thanks for letting us know about this. Based on this feedback, I have updated the priority of this issue. |
DominicKramer
added a commit
to DominicKramer/cloud-debug-nodejs
that referenced
this issue
Jun 11, 2018
DominicKramer
added a commit
that referenced
this issue
Jun 12, 2018
This issue has been fixed and released in version 2.6.0. If you are still encountering problems, please let me know. Thanks. |
@DominicKramer The issue I reported above (unable to add breakpoints after end of original file) is still happening, although the original submitted issue (breakpoints moving) seems to be fixed. |
Thank you for letting us know about this issue. I have created issue #464 specifically to track not being able to add breakpoints after the end of the original file. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: clouddebugger
Issues related to the googleapis/cloud-debug-nodejs API.
🚨
This issue needs some love.
triage me
I really want to be triaged.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
After applying #402 locally, I managed to get the stackdriver debugger to work. The problem is that if I set a breakpoint on a typescript file the breakpoint line will change when the breakpoint hits
Before hitting
![image](https://user-images.githubusercontent.com/4530263/38971821-520798f4-4373-11e8-9c89-2c463892ecb6.png)
![image](https://user-images.githubusercontent.com/4530263/38971838-5cb528ac-4373-11e8-8ad9-4197c736cd79.png)
After hitting
I believe that the problem is on https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/blob/master/src/agent/v8/legacy-debugapi.ts#L461 and https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/blob/master/src/agent/v8/inspector-debugapi.ts#L469 which changes the line number to the one set in the call frames. The problem is that the call frames refer to another file (the javascript file) and not the original typescript file where I set the breakpoint.
The text was updated successfully, but these errors were encountered: