Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Unable to add breakpoints after end of original file #464

Closed
DominicKramer opened this issue Jul 11, 2018 · 0 comments
Closed

Unable to add breakpoints after end of original file #464

DominicKramer opened this issue Jul 11, 2018 · 0 comments
Assignees
@DominicKramer
Labels
api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@DominicKramer
Copy link
Contributor

Issue #417 consisted of two problems. PR #436 was created to fix all of issue #417, but the problem listed below is still and issue.

This has an additional impact which is that breakpoints set on a line after compiled file ends won't work at all. For example, my user.ts file has 519 lines. Compiled as user.js, it has 434 lines. I can't add a breakpoint to user.ts after line 434

image
@DominicKramer DominicKramer added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 11, 2018
@DominicKramer DominicKramer self-assigned this Jul 11, 2018
@DominicKramer DominicKramer mentioned this issue Jul 11, 2018
Closed
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jul 16, 2018
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jul 26, 2018
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Aug 5, 2018
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Aug 15, 2018
DominicKramer added a commit to DominicKramer/cloud-debug-nodejs that referenced this issue Aug 28, 2018
@DominicKramer
fix: allow snapshots in shorter transpiled files
4e53557 
If a source file had `n` lines and was transpiled to a JavaScript
file with `m` lines with `m < n`, and one tried to set a snapshot
on a line between `m+1` and `n` in the original source file,
setting the snapshot would incorrectly fail with an error stating
that the requested line was beyond the size of the file.

Fixes: googleapis#464
@DominicKramer DominicKramer mentioned this issue Aug 28, 2018
Merged
DominicKramer added a commit that referenced this issue Aug 29, 2018
@DominicKramer
fix: allow snapshots in shorter transpiled files (#513)
9512bac 
If a source file had `n` lines and was transpiled to a JavaScript
file with `m` lines with `m < n`, and one tried to set a snapshot
on a line between `m+1` and `n` in the original source file,
setting the snapshot would incorrectly fail with an error stating
that the requested line was beyond the size of the file.

Fixes: #464
@DominicKramer DominicKramer removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Aug 29, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. label Jan 31, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DominicKramer DominicKramer

Labels
api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JustinBeckwith @DominicKramer @yoshi-automation