Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @google-cloud/common to v1 #1023

Merged
merged 2 commits into from
May 9, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 9, 2019

This PR contains the following updates:

Package Type Update Change References
@​google-cloud/common dependencies major ^0.32.1 -> ^1.0.0 source

Release Notes

googleapis/nodejs-common

v1.0.0

Compare Source

Bug Fixes
Build System
Miscellaneous Chores
BREAKING CHANGES
  • deps: this will ship async/await in the generated code
  • upgrade engines field to >=8.10.0 (#​412)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2019
@bcoe
Copy link
Contributor

bcoe commented May 9, 2019

could we get away with dropping Node 6 from the testing matrix in circleci?

@renovate renovate bot force-pushed the renovate/google-cloud-common-1.x branch from 8a05938 to 0400701 Compare May 9, 2019 19:20
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #1023 into master will increase coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1023     +/-   ##
=========================================
+ Coverage    94.5%   94.81%   +0.3%     
=========================================
  Files          97       97             
  Lines        6150     6150             
  Branches      486      486             
=========================================
+ Hits         5812     5831     +19     
+ Misses        183      165     -18     
+ Partials      155      154      -1
Impacted Files Coverage Δ
src/trace-writer.ts 92.43% <0%> (-1.69%) ⬇️
src/plugins/plugin-grpc.ts 86.02% <0%> (+1.07%) ⬆️
test/utils.ts 88.88% <0%> (+1.58%) ⬆️
src/plugins/plugin-hapi.ts 88.67% <0%> (+1.88%) ⬆️
src/plugins/plugin-mysql2.ts 75.67% <0%> (+2.7%) ⬆️
src/plugins/plugin-mysql.ts 97.29% <0%> (+2.7%) ⬆️
test/plugins/common.ts 95.52% <0%> (+2.98%) ⬆️
src/plugins/plugin-restify.ts 96.96% <0%> (+3.03%) ⬆️
src/plugins/plugin-http.ts 89.69% <0%> (+4.12%) ⬆️
src/plugins/plugin-express.ts 97.56% <0%> (+4.87%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d3b9e5...06da1a8. Read the comment docs.

@renovate
Copy link
Contributor Author

renovate bot commented May 9, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@JustinBeckwith JustinBeckwith merged commit 244633e into master May 9, 2019
@renovate renovate bot deleted the renovate/google-cloud-common-1.x branch May 9, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants