Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Reverse position on explicit "must exist" for update #82

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Jan 18, 2024

No description provided.

@jskeet jskeet requested a review from a team as a code owner January 18, 2024 11:02
@jskeet
Copy link
Collaborator Author

jskeet commented Jan 18, 2024

Denis: I'll give you context by chat.

@jskeet
Copy link
Collaborator Author

jskeet commented Jan 18, 2024

(The Kokoro failures are unrelated to this PR.)

@jskeet jskeet merged commit 3de4678 into googleapis:main Jan 18, 2024
3 of 4 checks passed
@jskeet jskeet deleted the firestore-must-exist branch January 18, 2024 16:35
dconeybe added a commit to googleapis/nodejs-firestore that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants