test: add tests for update with exists=false precondition #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jskeet FYI |
jskeet
approved these changes
Jan 22, 2024
jskeet
requested changes
Jan 22, 2024
| }, | ||
| "jsonData": "{\"a\": 1}", | ||
| "isError": true, | ||
| "request": { |
There was a problem hiding this comment.
As noted in chat, let's remove this given that it's meant to be an error.
jskeet
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Much clearer, thanks. And I've verified that it won't break the public API surface for .NET as we don't allow public specification of that precondition anywhere. (I'll need to add validation into the method in order to get the conformance tests to pass, but that's okay.)
|
@ddelgrosso1 Are you able and willing to give approval for this PR too? It's a follow-up to #82. Feel free to DM me and/or @jskeet if you would like any clarifications. Thank you. |
This was referenced Jan 22, 2024
dconeybe
added a commit
to dconeybe/java-conformance-tests
that referenced
this pull request
Jan 23, 2024
googleapis/conformance-tests@d160e3a chore: update go version to 1.21 ([googleapis#86](googleapis/conformance-tests#86)) googleapis/conformance-tests@76305a9 test: add tests for update with exists=false precondition ([googleapis#84](googleapis/conformance-tests#84)) googleapis/conformance-tests@3de4678 tests: Reverse position on explicit "must exist" for update googleapis/conformance-tests@3264aa6 chore: Reorder query parameters in expected URL for signature test Full diff: googleapis/conformance-tests@f5b5d0f...d160e3a
cojenco
pushed a commit
to googleapis/java-conformance-tests
that referenced
this pull request
Jan 23, 2024
…f19 (#643) googleapis/conformance-tests@d160e3a chore: update go version to 1.21 ([#86](googleapis/conformance-tests#86)) googleapis/conformance-tests@76305a9 test: add tests for update with exists=false precondition ([#84](googleapis/conformance-tests#84)) googleapis/conformance-tests@3de4678 tests: Reverse position on explicit "must exist" for update googleapis/conformance-tests@3264aa6 chore: Reorder query parameters in expected URL for signature test Full diff: googleapis/conformance-tests@f5b5d0f...d160e3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #82 which updated the test for the exists precondition.