This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
feat: add BigQuery proto library #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
coryan
changed the title
coryan
force-pushed
the
add-bigquery-proto-library
branch
from
e7097be
to
4e13982
Compare
devbww
approved these changes
Oct 16, 2019
tmatsuo
reviewed
Oct 16, 2019
| @@ -73,6 +73,14 @@ set(GOOGLEAPIS_CPP_PROTO_FILES | |||
| "google/bigtable/admin/v2/table.proto" | |||
| "google/bigtable/v2/bigtable.proto" | |||
| "google/bigtable/v2/data.proto" | |||
| "google/cloud/bigquery/v2/model_reference.proto" | |||
| "google/cloud/bigquery/v2/standard_sql.proto" | |||
| "google/cloud/bigquery/v2/model.proto" | |||
There was a problem hiding this comment.
Now I see:
https://github.com/googleapis/googleapis/blob/master/google/cloud/bigquery/v2/encryption_config.proto
also datatransfer and logging directory have some protos.
in googleapis repo. Does it make sense to include them too?
There was a problem hiding this comment.
Argh. I was looking at an older version of googleapis/googleapis. Yes, we probably need to update and add any new protos.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.