Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Add BUILD_BYPRODUCTS #9

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Add BUILD_BYPRODUCTS #9

merged 1 commit into from
Jul 18, 2019

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jul 18, 2019

It should fix the build failure with Ninja

@tmatsuo tmatsuo requested a review from coryan July 18, 2019 16:48
coryan
coryan approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
For a future PR: it would be nice to not list all the proto files, and maybe "deduce them" from the list of libraries. But I am not sure that is doable given the order we need to list things in.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 18, 2019

Thanks, just rebased to master.

@tmatsuo tmatsuo merged commit 8c2add0 into googleapis:master Jul 18, 2019
@tmatsuo tmatsuo deleted the build-byproducts branch July 18, 2019 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmatsuo @coryan