Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that single (Batch) DML statements are retried if aborted #28

Closed
olavloite opened this issue Dec 3, 2021 · 0 comments · Fixed by #43 or #123
Closed

Test that single (Batch) DML statements are retried if aborted #28

olavloite opened this issue Dec 3, 2021 · 0 comments · Fixed by #43 or #123
Assignees
@olavloite
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@olavloite
Copy link
Collaborator

The Connection API retries explicit transactions using a checksum strategy if these are aborted by Cloud Spanner. For single (Batch) DML statements the checksum strategy is overkill, and instead the underlying transactions should use the Spanner data client SpannerRetriableTransaction version.
@olavloite olavloite added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Dec 3, 2021
olavloite added a commit that referenced this issue Dec 13, 2021
@olavloite
fix: Ephemeral BatchDML commands were not retried if aborted
c306316 
BatchDML statements that were executed outside of an explicit transaction were not automatically retried if
the underlying transaction was aborted by Cloud Spanner.

Fixes #28
@olavloite olavloite mentioned this issue Dec 13, 2021
Merged
@olavloite olavloite self-assigned this Dec 14, 2021
olavloite added a commit that referenced this issue Dec 14, 2021
@olavloite
fix: Ephemeral BatchDML commands were not retried if aborted (#43)
45029da 
BatchDML statements that were executed outside of an explicit transaction were not automatically retried if
the underlying transaction was aborted by Cloud Spanner.

Fixes #28
@release-please release-please bot mentioned this issue Oct 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
1 participant
@olavloite