Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gengapic: fix linkParser regexp to support multi-line link tags #1097

Closed
noahdietz opened this issue Aug 3, 2022 · 0 comments · Fixed by #1098 or #1089
Closed

gengapic: fix linkParser regexp to support multi-line link tags #1097

noahdietz opened this issue Aug 3, 2022 · 0 comments · Fixed by #1098 or #1089
Assignees
@quartzmo
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@noahdietz
Copy link
Collaborator

This regexp should support any amount of whitespace between the <a and the href.
@noahdietz noahdietz added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Aug 3, 2022
@quartzmo quartzmo self-assigned this Aug 4, 2022
quartzmo added a commit to quartzmo/gapic-generator-go that referenced this issue Aug 4, 2022
@quartzmo
fix(gengapic): fix linkParser regexp to support multi-line link tags
e4cc62c 
closes: googleapis#1097
@quartzmo quartzmo mentioned this issue Aug 4, 2022
Merged
quartzmo added a commit to quartzmo/gapic-generator-go that referenced this issue Aug 4, 2022
@quartzmo
fix(gengapic): fix linkParser regexp to support multi-line link tags
f5949c5 
closes: googleapis#1097
quartzmo added a commit that referenced this issue Aug 4, 2022
@quartzmo
fix(gengapic): fix linkParser regexp to support multi-line link tags (#…
863675e 
…1098)

closes: #1097
@release-please release-please bot mentioned this issue Aug 4, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 16, 2022
@release-please
chore(main): release 0.32.0 (#1089)
a4d13ee 
🤖 I have created a release *beep* *boop*
---


## [0.32.0](v0.31.2...v0.32.0) (2022-08-16)


### Features

* **gengapic:** rest-numeric-enums option enables enum-encoding sys param ([#1022](#1022)) ([6bbbf6f](6bbbf6f))


### Bug Fixes

* **gengapic:** fix linkParser regexp to support multi-line link tags ([#1098](#1098)) ([863675e](863675e)), closes [#1097](#1097)
* **gengapic:** fix service-specific constructor name in doc_file.go ([#1099](#1099)) ([4f80726](4f80726)), closes [#1077](#1077)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@quartzmo @noahdietz