fix: handle wkt in paged requests #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahdietz
added
automerge
gcf-merge-on-green bot
pushed a commit
to googleapis/google-cloud-go
that referenced
this pull request
Sep 13, 2022
Includes fix for well-known types in query parameters of Paginated methods for REGAPICs googleapis/gapic-generator-go#1132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Standard List methods, and most other paginated methods, having fields in the request message outside of a resource name and the standard fields is non-compliant. However, there is at least one API that utilizes such non-standard fields, one of them being a well-known type that would end up being encoded in the query params. So that case needs to be supported.