Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gengapic): move top-level package doc links to top #1175

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

adrianajg
Copy link
Contributor

@adrianajg adrianajg commented Nov 1, 2022

Fixes #1140

@google-cla
Copy link

google-cla bot commented Nov 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adrianajg adrianajg marked this pull request as ready for review January 3, 2023 14:55
@adrianajg adrianajg requested review from a team as code owners January 3, 2023 14:55
@noahdietz
Copy link
Collaborator

Looks great! Can you add a short description and mention that this "fixes" the issue #1140 ? That way, once this is merged, the issue will be closed as fixed automatically.

@noahdietz noahdietz changed the title fix(gengapic): move top-level package docs link to more prominent pos… fix(gengapic): move top-level package doc links to top Jan 9, 2023
@noahdietz noahdietz added the automerge Summon MOG for automerging label Jan 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8cf6194 into googleapis:main Jan 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gengapic: move top-level package docs link to more prominent position
3 participants