Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SampleGen: write a string or bytes field of the response object to a local file #150

Merged
merged 5 commits into from
Jul 18, 2019
Merged

SampleGen: write a string or bytes field of the response object to a local file #150

merged 5 commits into from
Jul 18, 2019

Conversation

yihanzhen
Copy link
Contributor 

- on_success
    - write_file
        contents: $resp.i.am.a.bytes.field
        file_name:
        - "format_%s.mp3"
        - $resp.replace.the.placeholder.with.me

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2019
@yihanzhen
Copy link
Contributor Author

cc/ @googleapis/samplegen

@yihanzhen
Copy link
Contributor Author

PTAL

noahdietz
noahdietz reviewed Jul 17, 2019
View reviewed changes
cmd/gen-go-sample/testdata/sample_write_file.want Outdated Show resolved Hide resolved
cmd/gen-go-sample/out.go Outdated Show resolved Hide resolved
noahdietz
noahdietz approved these changes Jul 17, 2019
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yihanzhen yihanzhen merged commit 0b91ddf into googleapis:master Jul 18, 2019
vchudnov-g
vchudnov-g reviewed Jul 24, 2019
View reviewed changes
cmd/gen-go-sample/testdata/sample_write_file.want
@@ -0,0 +1,61 @@
// Copyright 2018 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g left review comments

@noahdietz noahdietz noahdietz approved these changes

@pongad pongad Awaiting requested review from pongad

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yihanzhen @vchudnov-g @noahdietz @googlebot