Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapic: enable updated googleapis test #173

Merged
merged 6 commits into from
Aug 10, 2019
Merged

gapic: enable updated googleapis test #173

merged 6 commits into from
Aug 10, 2019

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Aug 9, 2019 •
edited
Loading

  • updates test.sh to:
    • use just googleapis/googleapis protos
    • use some minimally annotated APIs
    • check for syntax errors in gen'd output
  • adds test.sh as a step in Circle CI testing job

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2019
@noahdietz noahdietz merged commit ca13906 into googleapis:master Aug 10, 2019
@noahdietz noahdietz deleted the update-googleapis-test branch August 10, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pongad pongad pongad approved these changes

@vchudnov-g vchudnov-g Awaiting requested review from vchudnov-g

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noahdietz @pongad @googlebot