feat: generate a default audience for clients #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option will be used to generate self-signed JWTs when the client is authenticated with a service account and the user does not provide additional scopes. Also, now marking the generated scopes as default so we can distinguish between generated and user provided scopes. Related: googleapis/google-api-go-client#738
google-cla
bot
added
the
cla: yes
codyoss
added
the
do not merge
|
Before this PR is merged:
|
|
cc @bshaffer |
vchudnov-g
approved these changes
Nov 3, 2020
|
|
||
| // generateDefaultAudience transforms a host into a an audience that can be used | ||
| // as the `aud` claim in a JWT. | ||
| func generateDefaultAudience(host string) string { |
There was a problem hiding this comment.
Are we guaranteed that the host is a proper host (ie doesn't have a path)? I'd be inclined to defensively remove it (and include that in tests).
There was a problem hiding this comment.
Guaranteed, no. But it does not happen today I can fairly certainly say. On L63 of this file we append :443 to the the end of the host. If there were path fragments this should be an invalid host and the client would not be able to talk to the backend.
codyoss
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option will be used to generate self-signed JWTs when the
client is authenticated with a service account and the user does
not provide additional scopes.
Also, now marking the generated scopes as default so we can
distinguish between generated and user provided scopes.
Related: googleapis/google-api-go-client#738