-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce next generation PHP client surface #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some dead code that should've been removed in #510.
* feat: introduce v2 client with new method signatures * allow fluent methods in fake message * update goldens
* feat: magic async methods * update integration goldens * use trigger_error, simplify call impl * switch to array_unshift/call_user_func_array * get rid of extra lines in method doc * use relative types for method docs
bshaffer
approved these changes
May 1, 2023
Co-authored-by: Brent Shaffer <betterbrent@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges all of the work staged in
v2-dev
. This includes the following:@experimental
client surface generated into the.../{Version}/Client
and../{Version}/Client/BaseClient
directoriesPostProcessor
s that can augment the generated tarball & its contentscallType
responseType
headerParams
templateMap
migration_mode
attribute with four values:PRE_MIGRATION_SURFACE_ONLY
: the current default, only generates the "v1" surfaceMIGRATION_MODE_UNSPECIFIED
: the future default, generates both, but snippets target "v1" surfaceMIGRATING
: generates both, but snippets target "v2" surfaceNEW_SURFACE_ONLY
: the default post-major version bump, only generates the "v2" surfacegax-php
version to1.19.1
for GAPICs8.1.13
8.1