Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce next generation PHP client surface #612

Merged
merged 38 commits into from
May 1, 2023
Merged

feat: introduce next generation PHP client surface #612

merged 38 commits into from
May 1, 2023

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Apr 17, 2023 •
edited
Loading

This merges all of the work staged in v2-dev. This includes the following:

  • new, @experimental client surface generated into the .../{Version}/Client and ../{Version}/Client/BaseClient directories
  • generation and injection of request builder fragments for Protobuf messages
  • the concept of PHP-based PostProcessors that can augment the generated tarball & its contents
  • increased request message tree search depth for resources-to-generate (fixes Generate resource name helpers for resources referenced at any level of request messages #453)
  • added descriptors in descriptor config including:
    • callType
    • responseType
    • headerParams
    • templateMap
  • temporary migration_mode attribute with four values:
    • PRE_MIGRATION_SURFACE_ONLY: the current default, only generates the "v1" surface
    • MIGRATION_MODE_UNSPECIFIED: the future default, generates both, but snippets target "v1" surface
    • MIGRATING: generates both, but snippets target "v2" surface
    • NEW_SURFACE_ONLY: the default post-major version bump, only generates the "v2" surface
  • Bumps required gax-php version to 1.19.1 for GAPICs
  • Bumps version of PHP in WORKSPACE to 8.1.13
  • Bumps min version of PHP for generator to 8.1

noahdietz and others added 30 commits August 15, 2022 11:02
@noahdietz
chore(ci): add v2-dev jobs (#507)
02a7dc4
@noahdietz
feat: switch to startApiCall with call descriptors (#510)
b72f1c9
@noahdietz
Merge branch 'main' into v2-dev
0f5d320
@noahdietz
Merge branch 'main' of https://github.com/googleapis/gapic-generator-php
3e99fdc 
 into v2-dev
@noahdietz
fix unit test goldens
b2fd505
@noahdietz
fix integration goldens
8e82495
@noahdietz
Merge branch 'main' of https://github.com/noahdietz/gapic-generator-php…
6db0d75 
… into v2-dev
@noahdietz
fix DiableSnippets baseline
721082d
@noahdietz
Merge branch 'main' into v2-dev
1aa1389
@noahdietz
Merge branch 'main' into v2-dev
0e47efd
@noahdietz
chore: cleanup dead code (#535)
af3a75a 
Removes some dead code that should've been removed in #510.
@dwsupplee
chore: revert startApiCall in gapic generator (#542)
17ff52a
@dwsupplee
Merge remote-tracking branch 'origin/main' into v2-dev
22f3bfb
@dwsupplee
update goldens
6021a20
@dwsupplee
feat: introduce v2 client with new method signatures (#543)
da0d00c 
* feat: introduce v2 client with new method signatures

* allow fluent methods in fake message

* update goldens
@noahdietz
feat(v2): generate ResourceHelperTrait and helpers (#551)
5ac7ad0
@noahdietz
feat: upgrade repo to PHP 8.1.13 (#553)
6cbb466
@noahdietz
Merge branch 'main' into v2-dev
36aba8d
@noahdietz
chore(v2): update license year in v2 clients (#563)
2b8530a
@noahdietz
feat(v2): magic async methods (#564)
18ec007 
* feat: magic async methods

* update integration goldens

* use trigger_error, simplify call impl

* switch to array_unshift/call_user_func_array

* get rid of extra lines in method doc

* use relative types for method docs
@noahdietz
fix(v2): correct spacing in __call error (#568)
f7720c1
@bshaffer
feat: add request builder snippets (#571)
1802d97
@noahdietz
fix(bazel): exclude fragment files from package (#592)
febb71e
@noahdietz
fix(v2): final empty classes, internal base classes (#593)
5fd3704
@saranshdhingra
feat: make client constants private (#599)
bcea84e
@noahdietz
fix(v2): mark new classes experimental (#595)
85af7ee
@saranshdhingra
chore: Rename optionalArgs to callOptions (#596)
d3f495d
@saranshdhingra
chore: Make GAPIC client classes abstract (#601)
9ff6873
@noahdietz
chore: various fixes from PoC review (#603)
c1ce3a9
@noahdietz
feat(v2): introduce migration_mode, default to v1 (#606)
1b2af15
@noahdietz noahdietz marked this pull request as ready for review April 27, 2023 17:55
@noahdietz noahdietz requested review from a team as code owners April 27, 2023 17:55
bshaffer
bshaffer approved these changes May 1, 2023
View reviewed changes
.github/workflows/bazel_example.yml Outdated Show resolved Hide resolved
src/Ast/AST.php Outdated Show resolved Hide resolved
.github/workflows/phpunit.yml Outdated Show resolved Hide resolved
noahdietz and others added 2 commits May 1, 2023 10:24
@noahdietz @bshaffer
Update src/Ast/AST.php
65e6408 
Co-authored-by: Brent Shaffer <betterbrent@google.com>
@noahdietz
remove v2-dev from workflows
f173824
@noahdietz noahdietz merged commit c675c3d into main May 1, 2023
5 checks passed
@noahdietz noahdietz deleted the v2-dev branch May 1, 2023 17:45
@release-please release-please bot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate resource name helpers for resources referenced at any level of request messages
4 participants
@noahdietz @bshaffer @dwsupplee @saranshdhingra