Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove oneof wrappers in v2 #629

Merged
merged 8 commits into from
May 10, 2023
Merged

fix: remove oneof wrappers in v2 #629

merged 8 commits into from
May 10, 2023

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented May 10, 2023

fixes #628

  • Removes use of OneOf wrapper classes in V2 tests
  • Removes use of OneOf wrapper classes in V2 samples
  • Skips generating OneOf wrapper classes for MigrationMode::NEW_SURFACE_ONLY

@bshaffer bshaffer requested review from a team as code owners May 10, 2023 18:43
@snippet-bot
Copy link

snippet-bot bot commented May 10, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bshaffer bshaffer changed the title fix: oneof tests for v2 fix: remove oneof wrappers in v2 May 10, 2023
@bshaffer bshaffer requested a review from noahdietz May 10, 2023 22:55
@bshaffer bshaffer merged commit f69fcfb into main May 10, 2023
5 checks passed
@bshaffer bshaffer deleted the fix-oneof-for-v2 branch May 10, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: "OneOf" GAPIC class is used in tests instead of protobuf oneof
2 participants