fix: include non-required resource fields in helpers #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 31, 2023
🤖 I have created a release *beep* *boop* --- ## [1.7.6](https://togithub.com/googleapis/gapic-generator-php/compare/v1.7.5...v1.7.6) (2023-05-31) ### Bug Fixes * Include non-required resource fields in helpers ([#635](https://togithub.com/googleapis/gapic-generator-php/issues/635)) ([bd1be34](https://togithub.com/googleapis/gapic-generator-php/commit/bd1be349e6c75e6e529572f9948189dfbc1f8df1)) * Increase php memory limit ([#631](https://togithub.com/googleapis/gapic-generator-php/issues/631)) ([685b419](https://togithub.com/googleapis/gapic-generator-php/commit/685b419f2220e2d19c74e7f1464067f995cf1a95)) * Update PHP prebuilt binary, version 8.1.13 ([#634](https://togithub.com/googleapis/gapic-generator-php/issues/634)) ([29be36e](https://togithub.com/googleapis/gapic-generator-php/commit/29be36e9541a15edbee4dd037489de41ca6f7180)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the algorithm for identifying resources in scope of helper generation only traversed fields of type message that were annotated as required (and of course, represented a resource). This resulted in some such fields being excluded from helper generation, when they are in fact part of the request message tree.
This just removes that check on
isRequiredfield, bringing such references in scope.Updates #453