Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new surface custom LROs #712

Merged
merged 8 commits into from
May 30, 2024
Merged

feat: new surface custom LROs #712

merged 8 commits into from
May 30, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented May 20, 2024

See googleapis/gax-php#569 and googleapis/gax-php#570

Adds configuration for Request classes for custom operations, which is required for V2

Also ensures that "DIREGAPIC Enums" are not generated for new surface clients.

@bshaffer bshaffer changed the title feat: add request classes for v2 feat: add LRO request classes for v2 May 21, 2024
@bshaffer bshaffer changed the title feat: add LRO request classes for v2 feat: add custom LRO request classes for v2 May 28, 2024
@bshaffer bshaffer marked this pull request as ready for review May 29, 2024 20:45
@bshaffer bshaffer requested review from a team as code owners May 29, 2024 20:45
Copy link

snippet-bot bot commented May 29, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bshaffer bshaffer changed the title feat: add custom LRO request classes for v2 feat: new surface custom LROs May 30, 2024
@bshaffer bshaffer merged commit 0afff0f into main May 30, 2024
4 checks passed
@bshaffer bshaffer deleted the custom-operations-client-v2 branch May 30, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants