Skip to content

Commit

Permalink
fix: femove vars and setfrom reserved names (#1451)
Browse files Browse the repository at this point in the history
This fixes #1348. This is also backwar compatible with already released clients dataform and network-services, because removal of unnecessary `_` is already happening in ppostprocesing scripts for those two affected apis.
  • Loading branch information
vam-google committed Sep 15, 2022
1 parent 4df65b7 commit ae3e6bf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion gapic/utils/reserved_names.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
# We CANNOT make exceptions for keywords.
keyword.kwlist,
# We make SOME exceptions for certain names that collide with builtins.
set(dir(builtins)) - {"filter", "map", "id", "input", "property"},
set(dir(builtins)) - {"filter", "map", "id",
"input", "property", "vars", "set"},
# "mapping" and "ignore_unknown_fields" have special uses
# in the constructor of proto.Message
{"mapping", "ignore_unknown_fields"},
Expand Down

0 comments on commit ae3e6bf

Please sign in to comment.