Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore_unknown_fields parsing service config #1618

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix: ignore_unknown_fields parsing service config #1618

merged 3 commits into from
Mar 14, 2023

Conversation

noahdietz
Copy link
Contributor

Enables ignore_unknown_fields behavior while parsing the google.api.Service config YAML file. This will make the Python generator resilient to parsing a Service config with fields that it hasn't received the updated proto for yet.

cc: @jskeet @alexander-fenster

@noahdietz noahdietz requested review from a team as code owners March 10, 2023 23:17
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 10, 2023
@noahdietz @alexander-fenster
reformat args
574fc67 
Co-authored-by: Alexander Fenster <fenster@google.com>
@noahdietz
Copy link
Contributor Author

@parthea @atulep is this OK to do?

@parthea parthea merged commit de6386f into main Mar 14, 2023
@parthea parthea deleted the service-ignore-unknown branch March 14, 2023 11:29
@release-please release-please bot mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster left review comments

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahdietz @alexander-fenster @parthea