Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate import statement for google.longrunning.operations_pb2 in python-logging #1727

Closed
parthea opened this issue Aug 9, 2023 · 2 comments · Fixed by #1726
Closed

Duplicate import statement for google.longrunning.operations_pb2 in python-logging #1727

parthea opened this issue Aug 9, 2023 · 2 comments · Fixed by #1726
Assignees

Comments

@parthea
Copy link
Contributor

parthea commented Aug 9, 2023

In PR googleapis/python-logging#746, there is a duplicate import statement for google.longrunning.operations_pb2. See the review comment here.

@parthea
Copy link
Contributor Author

parthea commented Aug 9, 2023

I was able to re-create the issue in 5e03e71 using the latest version of googleapis/googleapis . #1726 fixes the problem. I had to back out the update of googleapis/googleapis in #1726 because it caused a large change to the golden files. The update of googleapis/googleapis should be done in a separate PR.

@parthea parthea self-assigned this Aug 9, 2023
@parthea
Copy link
Contributor Author

parthea commented Aug 10, 2023

I had to back out the addition of service YAML files in #1726 because it caused a large change to the golden files. The addition of service YAMLs should be done in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant