fix: remove duplicate import statement for google.longrunning.operations_pb2
#1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
changed the title
google.longrunning.operations_pb2
gcf-owl-bot
bot
removed
the
owlbot:run
product-auto-label
bot
added
size: m
parthea
force-pushed
the
update-googleapis-2
branch
from
7f2c8ed
to
c65f63d
Compare
vchudnov-g
approved these changes
Aug 23, 2023
| @@ -18,9 +18,14 @@ from google.auth import credentials as ga_credentials # type: ignore | |||
| from google.oauth2 import service_account # type: ignore | |||
|
|
|||
| {% filter sort_lines %} | |||
| {% set import_ns = namespace(has_operations_mixin=false) %} | |||
There was a problem hiding this comment.
It seems like this may need to be generalized to the other mixins. WDYT?
I don't think we should block on that, but I would add a TODO in the code and reference this PR.
vchudnov-g
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1727 馃