Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add additional reserved names for disambiguation #1114

Merged
merged 3 commits into from
Dec 28, 2021
Merged

fix: add additional reserved names for disambiguation #1114

merged 3 commits into from
Dec 28, 2021

Commits on Dec 15, 2021

  1. fix: add additional reserved names for disambiguation 

    The monikers "mapping" and "ignore_unknown_fields" have reserved
meaning in the constructor of proto.Message and therefore any fields
with those names need disambiguation.
    @software-dov
    software-dov committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    8aad2ee View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Don't be so lazy with the test for the new reserved name

    @software-dov
    software-dov committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    49b5425 View commit details
    Browse the repository at this point in the history

  2. Fix an import

    @software-dov
    software-dov committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    27acba2 View commit details
    Browse the repository at this point in the history