Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix issue in tests related to json serialization #1684

Merged
merged 2 commits into from
Jul 5, 2023
Merged

test: fix issue in tests related to json serialization #1684

merged 2 commits into from
Jul 5, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 5, 2023

Fixes #1683

The issue is that there is an incorrect assumption that dependencies will always have pb2 types instead of proto-plus types.

@parthea parthea requested review from a team as code owners July 5, 2023 19:15
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 5, 2023
@parthea parthea mentioned this pull request Jul 5, 2023
Merged
1 task
@parthea parthea merged commit 365da92 into main Jul 5, 2023
51 checks passed
@parthea parthea deleted the fix-test-proto-plus-types branch July 5, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizcology dizcology dizcology approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rest unit tests in python-oslogin fail with Unknown field for SshPublicKey: DESCRIPTOR
2 participants
@parthea @dizcology