Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a separate DEFAULT_CLIENT_INFO for rest clients #988

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

jameslynnwu
Copy link
Contributor

Previously, DEFAULT_CLIENT_INFO would be used for rest transports. However, if you generated both rest and grpc transports, rest version information would appear in both transport's client_infos. Now, we create our own DEFAULT_CLIENT_INFO for rest clients and copy the common information from the base DEFAULT_CLIENT_INFO.

@jameslynnwu jameslynnwu requested a review from a team as a code owner September 9, 2021 19:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2021
@jameslynnwu jameslynnwu marked this pull request as draft September 9, 2021 19:53
@tseaver tseaver changed the title Add a separate DEFAULT_CLIENT_INFO for rest clients fix: add a separate DEFAULT_CLIENT_INFO for rest clients Sep 9, 2021
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@jameslynnwu jameslynnwu marked this pull request as ready for review September 9, 2021 21:28
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants