-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Client to positional args #155
Switch Client to positional args #155
Conversation
gapic-generator/templates/default/service/client/method/docs/_request_normal.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. (Don't forget to change gem "google-gax", github: "blowmage/gax-ruby", branch: "2.0/client-methods-positional"
.)
gapic-generator/templates/default/service/client/method/docs/_request_normal.erb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the documentation of the request attributes!
This PR changes the Client RPC methods to use positional arguments instead of the mixed positional/named arguments. This is needed to work around Protobuf adding the
#to_hash
method to the resource classes.This PR is dependent on googleapis/gax-ruby#208.