fix: preserve existing query string parameters when adding enum encod…

…ing option (#1414)
googleapis · Feb 2, 2023 · 24f5e81 · 24f5e81
1 parent 5ea865c
commit 24f5e81
Show file tree

Hide file tree

Showing 4 changed files with 287 additions and 25 deletions.
diff --git a/src/fallbackRest.ts b/src/fallbackRest.ts
@@ -62,7 +62,8 @@ export function encodeRequest(
   // If numeric enums feature is requested, add extra parameter to the query string
   if (numericEnums) {
     transcoded.queryString =
-      (transcoded.queryString ? '&' : '') + '$alt=json%3Benum-encoding=int';
+      (transcoded.queryString ? `${transcoded.queryString}&` : '') +
+      '$alt=json%3Benum-encoding=int';
   }
 
   // Converts httpMethod to method that permitted in standard Fetch API spec

diff --git a/test/fixtures/google/example/library/v1/library.proto b/test/fixtures/google/example/library/v1/library.proto
@@ -148,6 +148,9 @@ message Shelf {
 message CreateShelfRequest {
   // The shelf to create.
   Shelf shelf = 1;
+
+  // Some query string parameter
+  string query_string_parameter = 2;
 }
 
 // Request message for LibraryService.GetShelf.