Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve existing query string parameters when adding enum encoding option #1414

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Feb 2, 2023

Background: to enable numeric enum responses for the REST transport, the client must add $alt=json%3Benum-encoding=int to the query string.

Apparently, the logic that added the parameter did not preserve the existing query string content, so the requests that relied on query strings failed. We don't have that many requests relying on query strings, but the one failing in Firestore (just one from the whole test suite) was one of them.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Feb 2, 2023
@alexander-fenster alexander-fenster merged commit 24f5e81 into main Feb 2, 2023
@alexander-fenster alexander-fenster deleted the fix-numeric-enums branch February 2, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants