Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade proto-loader and add long dev dependency #1253

Merged
merged 2 commits into from
May 5, 2022
Merged

fix: upgrade proto-loader and add long dev dependency #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c489ff
fix: upgrade proto-loader and add long dev dependency
summer-ji-eng May 5, 2022
535ddbb
change import line
summer-ji-eng May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"dependencies": {
"@grpc/grpc-js": "~1.6.0",
"@grpc/proto-loader": "0.6.9",
"@grpc/proto-loader": "^0.6.12",
"@types/long": "^4.0.0",
"abort-controller": "^3.0.0",
"duplexify": "^4.0.0",
Expand Down Expand Up @@ -60,6 +60,7 @@
"karma-sourcemap-loader": "^0.3.7",
"karma-webpack": "^5.0.0",
"linkinator": "^2.0.0",
"long": "^4.0.0",
"mkdirp": "^1.0.0",
"mocha": "^9.0.0",
"ncp": "^2.0.0",
Expand All @@ -73,7 +74,7 @@
"ts-loader": "^9.0.0",
"typescript": "^3.8.3",
"walkdir": "^0.4.0",
"webpack": "^4.34.0",
"webpack": "^5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sneaked in - I don't think it's related to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I got dependency tree error because karmar-webpack ask for 5.0.0. Without this update, it cause fails on npm install.

"webpack-cli": "^4.0.0"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion protos/iam_service.d.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion protos/operations.d.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/fixtures/google-gax-packaging-test-app/protos/protos.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import * as Long from "long";
import Long = require('long');
import {protobuf as $protobuf} from "../../../../src";
/** Namespace google. */
export namespace google {
Expand Down