Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve existing query string parameters when adding enum encoding option #1414

Merged
merged 1 commit into from
Feb 2, 2023
Merged

fix: preserve existing query string parameters when adding enum encoding option #1414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/fallbackRest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ export function encodeRequest(
// If numeric enums feature is requested, add extra parameter to the query string
if (numericEnums) {
transcoded.queryString =
(transcoded.queryString ? '&' : '') + '$alt=json%3Benum-encoding=int';
(transcoded.queryString ? `${transcoded.queryString}&` : '') +
'$alt=json%3Benum-encoding=int';
}

// Converts httpMethod to method that permitted in standard Fetch API spec
Expand Down
3 changes: 3 additions & 0 deletions test/fixtures/google/example/library/v1/library.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ message Shelf {
message CreateShelfRequest {
// The shelf to create.
Shelf shelf = 1;

// Some query string parameter
string query_string_parameter = 2;
}

// Request message for LibraryService.GetShelf.
Expand Down
Loading