Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal tags, remove Message from Call #223

Merged
merged 4 commits into from Dec 14, 2018
Merged

Add internal tags, remove Message from Call #223

merged 4 commits into from Dec 14, 2018

Conversation

michaelbausor
Copy link
Contributor

WIP PR to add internal tags and remove references in Call to protobuf Message class, PTAL.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 13, 2018
dwsupplee
dwsupplee reviewed Dec 14, 2018
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. What do you think about marking the GapicClientTrait internal as well? That will leave us flexibility to loosen the types on signatures such as startCall.

src/Call.php Outdated
@@ -53,14 +51,14 @@ class Call
/**
* @param string $method
* @param string $decodeType
* @param Message $message
* @param mixed $message

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@michaelbausor
Copy link
Contributor Author

I don't think we can do that with GapicClientTrait. It is used in generated code. If we change it in a breaking way, then anyone who upgrades their gax version but doesn't upgrade their generated code would be broken. But if we want to change it in a non-breaking way, then we are fine to do that even if it isn't marked internal. Does that make sense?

@codecov-io
Copy link

codecov-io commented Dec 14, 2018 •
edited

Codecov Report

Merging #223 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files          68       68           
  Lines        2552     2552           
=======================================
  Hits         2220     2220           
  Misses        332      332
Impacted Files Coverage Δ
src/RequestBuilder.php 93.65% <ø> (ø) ⬆️
src/UriTrait.php 100% <ø> (ø) ⬆️
src/Page.php 72.6% <ø> (ø) ⬆️
src/Call.php 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbec14b...e70e659. Read the comment docs.

@dwsupplee
Copy link
Contributor

Yeah, it does - good call.

@michaelbausor michaelbausor changed the title WIP: Add internal tags Add internal tags, remove Message from Call Dec 14, 2018
@michaelbausor
Copy link
Contributor Author

Ready for review, PTAL

@michaelbausor michaelbausor merged commit f63f096 into googleapis:master Dec 14, 2018
@michaelbausor michaelbausor deleted the add-internal-tags branch December 14, 2018 22:18
@michaelbausor michaelbausor mentioned this pull request Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaelbausor @codecov-io @dwsupplee @googlebot