Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal tags, remove Message from Call #223

Merged
merged 4 commits into from Dec 14, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Call.php
Expand Up @@ -53,14 +53,14 @@ class Call
/**
* @param string $method
* @param string $decodeType
* @param Message $message
* @param mixed|Message $message
* @param array $descriptor
* @param int $callType
*/
public function __construct(
$method,
$decodeType,
Message $message = null,
$message = null,
$descriptor = [],
$callType = Call::UNARY_CALL
) {
Expand Down Expand Up @@ -96,7 +96,7 @@ public function getDecodeType()
}

/**
* @return Message
* @return mixed|Message
*/
public function getMessage()
{
Expand All @@ -112,10 +112,10 @@ public function getDescriptor()
}

/**
* @param Message $message
* @param mixed|Message $message
* @return Call
*/
public function withMessage(Message $message)
public function withMessage($message)
{
return new static(
$this->method,
Expand Down
4 changes: 2 additions & 2 deletions src/Page.php
Expand Up @@ -196,7 +196,7 @@ public function iteratePages()
/**
* Gets the request object used to generate the Page.
*
* @return \Google\Protobuf\Internal\Message
* @return mixed|Message
*/
public function getRequestObject()
{
Expand All @@ -206,7 +206,7 @@ public function getRequestObject()
/**
* Gets the API response object.
*
* @return \Google\Protobuf\Internal\Message
* @return mixed|Message
*/
public function getResponseObject()
{
Expand Down
2 changes: 2 additions & 0 deletions src/RequestBuilder.php
Expand Up @@ -42,6 +42,8 @@

/**
* Builds a PSR-7 request from a set of request information.
*
* @internal
*/
class RequestBuilder
{
Expand Down
2 changes: 2 additions & 0 deletions src/UriTrait.php
Expand Up @@ -37,6 +37,8 @@

/**
* Provides a light wrapper around often used URI related functions.
*
* @internal
*/
trait UriTrait
{
Expand Down