Update grpc creds #91
Conversation
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 89.16% 90.29% +1.12%
==========================================
Files 32 33 +1
Lines 2179 2205 +26
==========================================
+ Hits 1943 1991 +48
+ Misses 236 214 -22
Continue to review full report at Codecov.
|
|
@garrettjonesgoogle @shinfan @neozwu Hi all, gentle ping on this after fixit week |
|
Is there PR fully auto-updated from the toolkit change? Is there any manual update? |
|
@shinfan Are you asking if this PR is completely auto-generated? This PR does contain manual changes, but also adds autogenerated files for longrunning (sorry if this is not what you meant) |
| $credentialsLoader = $opts['credentialsLoader']; | ||
| } else { | ||
| $credentialsLoader = $this->getADCCredentials($scopes); | ||
| if (empty($args['credentialsLoader'])) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/GrpcCredentialsHelper.php
Outdated
| /** | ||
| * Creates a gRPC client stub. | ||
| * | ||
| * @param callable $generatedCreateStub | ||
| * Function callback which must accept two arguments ($hostname, $opts) | ||
| * Function callback which must accept two arguments ($hostname, $opts, $channel) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/GrpcCredentialsHelper.php
Outdated
| /** | ||
| * Creates a gRPC client stub. | ||
| * | ||
| * @param callable $generatedCreateStub | ||
| * Function callback which must accept two arguments ($hostname, $opts) | ||
| * Function callback which must accept two arguments ($hostname, $opts, $channel) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| $credentialsLoader = $opts['credentialsLoader']; | ||
| } else { | ||
| $credentialsLoader = $this->getADCCredentials($scopes); | ||
| if (empty($args['credentialsLoader'])) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Restructure grpcCredentialsHelpers and add support for passing the Channel and forceNewChannel parameters.
Corresponding toolkit PR: googleapis/gapic-generator#1454
cc @dwsupplee @jdpedrie