Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf 3.4 and update to Serializer #92

Merged
merged 4 commits into from Aug 16, 2017

Conversation

michaelbausor
Copy link
Contributor

@michaelbausor michaelbausor commented Aug 8, 2017

This PR updates the protobuf dependency to the soon-to-be-released 3.4, and migrates the Serializer class to use the newly released descriptor classes.

It also contains minor bugfixes required to support the protobuf c extension, which from 3.4 onwards will be side-by-side compatible with the composer package.

NOTE: Travis is expected to fail until 3.4 is actually released.

@michaelbausor
Copy link
Contributor Author

@garrettjonesgoogle @shinfan @neozwu Hi all, gentle ping on this after fixit week

Copy link
Contributor

@shinfan shinfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we will need to remove these GPBXXX classes once the protobuf ones become public in the future.

@michaelbausor
Copy link
Contributor Author

Filed issue: #93

Copy link
Contributor

@shinfan shinfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after tests pass

@codecov-io
Copy link

codecov-io commented Aug 16, 2017

Codecov Report

Merging #92 into master will increase coverage by 1.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   89.16%   90.52%   +1.35%     
==========================================
  Files          32       33       +1     
  Lines        2179     2249      +70     
==========================================
+ Hits         1943     2036      +93     
+ Misses        236      213      -23
Impacted Files Coverage Δ
src/Testing/GeneratedTest.php 100% <100%> (ø) ⬆️
src/Serializer.php 93.25% <100%> (+1.75%) ⬆️
src/GrpcCredentialsHelper.php 100% <0%> (ø) ⬆️
src/BackoffSettings.php 100% <0%> (ø) ⬆️
src/LongRunning/OperationsClient.php
src/LongRunning/OperationsGapicClient.php 90.41% <0%> (ø)
src/ValidationTrait.php 83.33% <0%> (ø)
src/Testing/MockStubTrait.php 91.42% <0%> (+4.28%) ⬆️
src/Testing/SerializationTrait.php 92.85% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aacf4c6...ee6eb46. Read the comment docs.

@michaelbausor michaelbausor merged commit b648e74 into googleapis:master Aug 16, 2017
@michaelbausor michaelbausor deleted the update-serializer branch August 16, 2017 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants