New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf 3.4 and update to Serializer #92
Protobuf 3.4 and update to Serializer #92
Conversation
@garrettjonesgoogle @shinfan @neozwu Hi all, gentle ping on this after fixit week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, we will need to remove these GPBXXX classes once the protobuf ones become public in the future.
Filed issue: #93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after tests pass
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 89.16% 90.52% +1.35%
==========================================
Files 32 33 +1
Lines 2179 2249 +70
==========================================
+ Hits 1943 2036 +93
+ Misses 236 213 -23
Continue to review full report at Codecov.
|
This PR updates the protobuf dependency to the soon-to-be-released 3.4, and migrates the Serializer class to use the newly released descriptor classes.
It also contains minor bugfixes required to support the protobuf c extension, which from 3.4 onwards will be side-by-side compatible with the composer package.
NOTE: Travis is expected to fail until 3.4 is actually released.