Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reference error when run outside of nodejs #532

Closed
wants to merge 1 commit into from

Conversation

TechyShishy
Copy link

@TechyShishy TechyShishy commented Apr 3, 2023

Fix for #531, use optional chaining for the other instance of process in gaxios.ts, so that it matches the one above

Fixes #531 🦕

@TechyShishy TechyShishy requested a review from a team as a code owner April 3, 2023 00:54
@google-cla
Copy link

google-cla bot commented Apr 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 3, 2023
@TechyShishy TechyShishy marked this pull request as draft April 3, 2023 02:09
@danielbankhead
Copy link
Member

Thanks for this PR, however webpack should be used for using gaxios in the browser. Ref: #531 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError: process is not defined
2 participants