Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): Drop submodule backreferences #1087

Merged
merged 1 commit into from Feb 28, 2024
Merged

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Feb 12, 2024

Opening the PR to drop backreferences as the next step for #1015

Target for merging this is 2024-03-01.

After this is merged, we would ripple out require updates for the submodules that pruned backreferences, all the way up to the root genproto module.

cc @quartzmo

@liggitt liggitt requested a review from a team as a code owner February 12, 2024 13:38
@quartzmo quartzmo self-assigned this Feb 13, 2024
@quartzmo quartzmo added the type: cleanup An internal cleanup or hygiene concern. label Feb 13, 2024
@quartzmo
Copy link
Member

@liggitt Can you resolve conflicts in your branch? Once it's up to date, we'll merge this PR.

@liggitt
Copy link
Contributor Author

liggitt commented Feb 27, 2024

done

@liggitt liggitt changed the title [WIP] chore(all): Drop submodule backreferences chore(all): Drop submodule backreferences Feb 27, 2024
@quartzmo quartzmo enabled auto-merge (squash) February 27, 2024 21:09
auto-merge was automatically disabled February 27, 2024 22:01

Head branch was pushed to by a user without write access

@liggitt
Copy link
Contributor Author

liggitt commented Feb 27, 2024

rebased on master after #1090

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@liggitt
Copy link
Contributor Author

liggitt commented Feb 28, 2024

do you want me to rebase on master or leave this as-is?

@quartzmo
Copy link
Member

@liggitt Please rebase, thanks!

@liggitt
Copy link
Contributor Author

liggitt commented Feb 28, 2024

done

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2024
@quartzmo quartzmo merged commit 1f18d85 into googleapis:main Feb 28, 2024
12 checks passed
@liggitt
Copy link
Contributor Author

liggitt commented Feb 28, 2024

Opened #1093 to update the first set of submodules that reference just the ../rpc submodule

@liggitt
Copy link
Contributor Author

liggitt commented Feb 28, 2024

(successful bump of the rpc and api deps in kubernetes in kubernetes/kubernetes#123569)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants