Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pull batch URLs from API discovery document #620

Closed
erickoledadevrel opened this issue Oct 28, 2015 · 0 comments
Closed

Add ability to pull batch URLs from API discovery document #620

erickoledadevrel opened this issue Oct 28, 2015 · 0 comments
Assignees
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@erickoledadevrel
Copy link
Contributor

Newer APIs don't use the default batch URL ("https://www.googleapis.com/batch"). For example, the Classroom API uses "https://classroom.googleapis.com/batch", as indicated in it's discovery document:

{
  ...
 "baseUrl": "https://classroom.googleapis.com/",
 "basePath": "/",
 "rootUrl": "https://classroom.googleapis.com/",
 "servicePath": "",
 "batchPath": "batch",
  ...
}

Currently, developers must know to specify this URL when creating a batch request:

var batch = new BatchRequest(service, "https://classroom.googleapis.com/batch");

Ideally the client library would automatically determine the correct batch URL based on the service provided.

@LindaLawton LindaLawton added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. Component-CodeGeneration labels Nov 18, 2015
chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Mar 28, 2017
Only falls back to hard-coded value if batchPath not in discovery-doc

Fixes googleapis#923. Fixes googleapis#620
chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Mar 28, 2017
Only falls back to hard-coded value if batchPath not in discovery-doc

Fixes googleapis#923. Fixes googleapis#620
chrisdunelm added a commit that referenced this issue Mar 28, 2017
Only falls back to hard-coded value if batchPath not in discovery-doc

Fixes #923. Fixes #620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants