-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update batch endpoint to get URL from discovery #923
Comments
If you are referring to batchPath. How do you intend to check for APIs which don't support the normal Google API batching endpoint. Example:
Which appears to also have the batchPath set. The Google Analytics reporting API v4 does not support the normal Google API batching endpoint. |
@LindaLawton I'm working on this now. In what way does this not support the normal Google API batching endpoint? |
Only falls back to hard-coded value if batchPath not in discovery-doc Fixes googleapis#923. Fixes googleapis#620
Reporting API is batching by nature so it doesn't support the normal Google batching endpoint that would be double batching. I guess errors work I may speak with the team see if the endpoint should be removed |
OK, so after this change it'll fail in the same way that it used to if someone tries to use batching. |
Only falls back to hard-coded value if batchPath not in discovery-doc Fixes googleapis#923. Fixes googleapis#620
Discovery docs now include the path to the batch endpoint. This should be used instead of hardcoding it to /batch.
The text was updated successfully, but these errors were encountered: