Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update batch endpoint to get URL from discovery #923

Closed
chrisdunelm opened this issue Mar 2, 2017 · 4 comments
Closed

Update batch endpoint to get URL from discovery #923

chrisdunelm opened this issue Mar 2, 2017 · 4 comments
Assignees

Comments

@chrisdunelm
Copy link
Contributor

Discovery docs now include the path to the batch endpoint. This should be used instead of hardcoding it to /batch.

@LindaLawton
Copy link
Collaborator

If you are referring to batchPath. How do you intend to check for APIs which don't support the normal Google API batching endpoint.

Example:

https://www.googleapis.com/discovery/v1/apis/analyticsreporting/v4/rest

Which appears to also have the batchPath set. The Google Analytics reporting API v4 does not support the normal Google API batching endpoint.

@chrisdunelm
Copy link
Contributor Author

@LindaLawton I'm working on this now. In what way does this not support the normal Google API batching endpoint?
Retrieving the batch endpoint from the discovery doc will mean it will use "https://analyticsreporting.googleapis.com/batch".
Do you mean this API just doesn't support batching at all? In which case nothing will change, and users will get errors if they try to batch.
Or do you mean that the discovery-doc endpoint is wrong, and it must in fact use "http://www.googleapis.com/batch" (the current hard-coded value)?

chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Mar 28, 2017
Only falls back to hard-coded value if batchPath not in discovery-doc

Fixes googleapis#923. Fixes googleapis#620
@LindaLawton
Copy link
Collaborator

Reporting API is batching by nature so it doesn't support the normal Google batching endpoint that would be double batching.

I guess errors work I may speak with the team see if the endpoint should be removed

@chrisdunelm
Copy link
Contributor Author

OK, so after this change it'll fail in the same way that it used to if someone tries to use batching.
That's fine.
Thanks.

chrisdunelm added a commit to chrisdunelm/google-api-dotnet-client that referenced this issue Mar 28, 2017
Only falls back to hard-coded value if batchPath not in discovery-doc

Fixes googleapis#923. Fixes googleapis#620
chrisdunelm added a commit that referenced this issue Mar 28, 2017
Only falls back to hard-coded value if batchPath not in discovery-doc

Fixes #923. Fixes #620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants