Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): fix self-signed detection with scopes #1096

Merged
merged 3 commits into from
Jun 30, 2021
Merged

fix(internal): fix self-signed detection with scopes #1096

merged 3 commits into from
Jun 30, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jun 29, 2021

Removed the requirement on length of scopes passed. Checking the EnableJwtWithScope internal option should be sufficient since it will only be passed with our generated clients that will always include at least the platform scope and a default audience.
Fixes: #1092

@codyoss codyoss requested a review from broady June 29, 2021 17:53
@codyoss codyoss requested review from yoshi-approver and a team as code owners June 29, 2021 17:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2021
@codyoss
Copy link
Member Author

codyoss commented Jun 29, 2021

cc @shinfan

internal/creds.go Outdated Show resolved Hide resolved
internal/creds.go Outdated Show resolved Hide resolved
@codyoss codyoss merged commit ff1d20b into googleapis:master Jun 30, 2021
@codyoss codyoss deleted the id-auth-fix branch June 30, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idtoken package has been broken since v0.49.0 when service_account credential is used
3 participants