Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support structpb.Struct as req/resp #2632

Merged
merged 3 commits into from
Jun 12, 2024
Merged

feat: support structpb.Struct as req/resp #2632

merged 3 commits into from
Jun 12, 2024

Commits on Jun 12, 2024

  1. feat: support structpb.Struct as req/resp 

    There are some APIs that have started to use this type for the
request and/or respsonse. Similar to how we had to specially handle
protos HTTP body we need a good translation for this type as well.
`map[string]any` seemed like the best fit as that is the input
needed to create a `Struct`. The other choice would have been a
`googleapis.RawMessage`. RawMessage is used today when a field
would be of type Struct, but this is a less convient type, and less
precise type, to use than a map directly.

Fixes: googleapis#2601
    @codyoss
    codyoss committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9bcbecd View commit details
    Browse the repository at this point in the history

  2. Update google-api-go-generator/gen.go 

    Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
    @codyoss @noahdietz
    codyoss and noahdietz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    83106d0 View commit details
    Browse the repository at this point in the history

  3. fixup types

    @codyoss
    codyoss committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e1e0bb0 View commit details
    Browse the repository at this point in the history