Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport/grpc): check Compute Engine environment for DirectPath #781

Merged
merged 3 commits into from Dec 9, 2020

Conversation

@mohanli-ml
Copy link
Contributor

@mohanli-ml mohanli-ml commented Dec 9, 2020

Add Compute Engine environment check since DirectPath can only be used on Compute Engine.

@mohanli-ml mohanli-ml requested a review from googleapis/yoshi-go-admins as a code owner Dec 9, 2020
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
transport/grpc/dial.go Outdated Show resolved Hide resolved
@codyoss codyoss changed the title fix: check Compute Engine environment for DirectPath fix(transport/grpc): check Compute Engine environment for DirectPath Dec 9, 2020
@mohanli-ml mohanli-ml requested a review from yoshi-approver as a code owner Dec 9, 2020
@mohanli-ml mohanli-ml requested a review from codyoss Dec 9, 2020
@codyoss
codyoss approved these changes Dec 9, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 89287b6 into googleapis:master Dec 9, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants