-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apis: generate homegraph api #1807
Conversation
- run the generate - clean up the diff to only include homegraph changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple nits, but this is looking pretty solid.
|
||
import { | ||
AuthPlus, | ||
getAPI, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the linting looks a bit weird, i think you might need to run:
npm run fix
To fix the linting.
"devDependencies": { | ||
"gts": "^1.0.0", | ||
"null-loader": "^3.0.0", | ||
"ts-loader": "^6.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe that the generator generates with up-to-date dependencies, so you might want to update these accordingly.
Closing in favor of #1814, @JustinBeckwith just ran the whole generator. We'll make an effort to have this released for you shortly. |
@bcoe Thanks! and sorry for the lag ;) |
Let me know if you'd prefer to update all the generate API as part of the bigger CL instead.
Fixes #1806