New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying rootUrl at runtime #756
Conversation
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
=======================================
Coverage 79.49% 79.49%
=======================================
Files 5 5
Lines 239 239
Branches 53 53
=======================================
Hits 190 190
Misses 30 30
Partials 19 19 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, go ahead and remove everything from your PR except your changes to templates/method-partial.ts and the test file.
dfb03a4
to
5fcbc1e
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Ok, rebased on latest master and only did the commit with the test and template changes. 👍 Note that the tests will fail until APIs are regenerated... |
This can be useful for testing (pointing clients at `localhost`) or proxying (if for some reason the `proxy` option is insufficient). Test Plan: * Added new test. * `npm run generate-apis && npm run build && npm run test`
CLAs look good, thanks! |
Looks good, thanks! |
This can be useful for testing (pointing clients at
localhost
) or proxying (if for some reason theproxy
option is insufficient).Note that I am still using
buildurl
, though I am only building url fragments. Perhaps it should be renamed toescapeurl
, as it doesn't even really build a url...I did not squash so you could see the template changes vs the generated api code changes. Let me know if you want me to do so.
npm test
succeedsapis/