Skip to content

Commit

Permalink
fix: remove error block of code (#2163)
Browse files Browse the repository at this point in the history
  • Loading branch information
bshaffer committed Dec 2, 2021
1 parent 392c5c7 commit 1530583
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -40,7 +40,7 @@ composer installed.
Once composer is installed, execute the following command in your project root to install this library:

```sh
composer require google/apiclient:^2.12
composer require google/apiclient:^2.12.1
```

Finally, be sure to include the autoloader:
Expand All @@ -61,7 +61,7 @@ you want to keep in `composer.json`:
```json
{
"require": {
"google/apiclient": "^2.12"
"google/apiclient": "^2.12.1"
},
"scripts": {
"pre-autoload-dump": "Google\\Task\\Composer::cleanup"
Expand Down
9 changes: 1 addition & 8 deletions src/Client.php
Expand Up @@ -49,7 +49,7 @@
*/
class Client
{
const LIBVER = "2.12.0";
const LIBVER = "2.12.1";
const USER_AGENT_SUFFIX = "google-api-php-client/";
const OAUTH2_REVOKE_URI = 'https://oauth2.googleapis.com/revoke';
const OAUTH2_TOKEN_URI = 'https://oauth2.googleapis.com/token';
Expand Down Expand Up @@ -1255,13 +1255,6 @@ private function createApplicationDefaultCredentials()
$credentials->setSub($sub);
}

if ($credentials instanceof ServiceAccountCredentials && $this->isUsingJwtWithScope()) {
// tell the credentials to sign scopes into Self-Signed JWTs instead of
// calling the OAuth2 token endpoint
// @see https://google.aip.dev/auth/4111#scope-vs-audience
$credentials->useJwtAccessWithScope();
}

// If we are not using FetchAuthTokenCache yet, create it now
if (!$credentials instanceof FetchAuthTokenCache) {
$credentials = new FetchAuthTokenCache(
Expand Down

0 comments on commit 1530583

Please sign in to comment.