Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and populate folder for static discovery documents #1103

Closed
parthea opened this issue Nov 25, 2020 · 0 comments · Fixed by #1104
Closed

Create and populate folder for static discovery documents #1103

parthea opened this issue Nov 25, 2020 · 0 comments · Fixed by #1104
Assignees
@parthea
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@parthea
Copy link
Contributor

parthea commented Nov 25, 2020

googleapiclient downloads the discovery docs for a Google API service at runtime and then constructs a client. Issue #1063 captures the need to move to a static package where the discovery docs are not fetched at run time. An incremental step towards satisfying #1063 would be to create a folder with static Google API discovery documents in this repo. The discoveries folder in the googleapis/discovery-artifact-manager repo has an up to date copy of the discovery documents. One approach would be to modify synth.py to copy the discovery documents from discovery-artifact-manager similar to how it is done here.
@parthea parthea self-assigned this Nov 25, 2020
@parthea parthea added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 25, 2020
@parthea parthea mentioned this issue Nov 25, 2020
Merged
4 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 26, 2020
@parthea
feat: Update synth.py to copy discovery files from discovery-artifact…
af918e8 
…-manager (#1104)

Update synth.py to copy discovery files from discovery-artifact-manager

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-api-python-client/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Closes #1103 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
1 participant
@parthea